Skip to content

Automation for SAT-32425 and SAT-42710 - #20888

Merged
vsedmik merged 4 commits into
SatelliteQE:masterfrom
LadislavVasina1:AutomationSAT-32425
Feb 26, 2026
Merged

Automation for SAT-32425 and SAT-42710#20888
vsedmik merged 4 commits into
SatelliteQE:masterfrom
LadislavVasina1:AutomationSAT-32425

Conversation

@LadislavVasina1

@LadislavVasina1 LadislavVasina1 commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Check that only 1 Library LCE option is displayed in the Host create form when the Any location is set.
Needs: SatelliteQE/airgun#2323

PRT test Cases example

image 
trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_only_single_library_option_in_create_form'
airgun: 2323

Summary by Sourcery

Tests:

  • Add a UI test that validates only a single Library lifecycle environment option appears in the Create Host form for the Any location context.

@LadislavVasina1 LadislavVasina1 self-assigned this Feb 26, 2026
@LadislavVasina1
LadislavVasina1 requested a review from a team as a code owner February 26, 2026 09:33
@LadislavVasina1 LadislavVasina1 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.18.z Introduced in or relating directly to Satellite 6.18 6.19.z labels Feb 26, 2026
@LadislavVasina1 LadislavVasina1 mentioned this pull request Feb 26, 2026
Merged
@LadislavVasina1

LadislavVasina1 commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author 
trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_only_single_library_option_in_create_form'
airgun: 2323

@sourcery-ai

sourcery-ai Bot commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Adds a new UI automation test to verify that only a single 'Library' lifecycle environment option is shown in the Host creation form when the location is set to 'Any location'.

File-Level Changes

Change Details Files
Add a UI test that validates only one 'Library' LCE option is present in the Host create form when using 'Any location'.
  • Introduce test_positive_only_single_library_option_in_create_form using target_sat UI session
  • Select the Default Organization and the 'Any location' location in the UI session
  • Open the Host create form and expand the LCE filter dropdown
  • Assert that the LCE filter content contains the string 'Library' exactly once
 tests/foreman/ui/test_host.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot reviewed Feb 26, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Satellite-QE

Satellite-QE commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

PRT Result

Build Number: 14493
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_positive_only_single_library_option_in_create_form --external-logging
Test Result : ========== 1 passed, 94 deselected, 8 warnings in 1117.66s (0:18:37) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 26, 2026
jnagare-redhat
jnagare-redhat approved these changes Feb 26, 2026
View reviewed changes

@jnagare-redhat jnagare-redhat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vsedmik
vsedmik approved these changes Feb 26, 2026
View reviewed changes

@vsedmik vsedmik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small proposal to consider, otherwise looks good.

Comment thread tests/foreman/ui/test_host.py Outdated
Comment thread tests/foreman/ui/test_host.py Outdated
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 26, 2026
@LadislavVasina1 LadislavVasina1 added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 26, 2026
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 26, 2026
@LadislavVasina1 LadislavVasina1 added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 26, 2026
This was referenced Feb 26, 2026
Merged
Merged
@vsedmik
vsedmik merged commit 427f1f9 into SatelliteQE:master Feb 26, 2026
11 checks passed
This was referenced Feb 26, 2026
Closed
Closed
This was referenced Feb 26, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
@vsedmik vsedmik vsedmik approved these changes
@jnagare-redhat jnagare-redhat jnagare-redhat approved these changes
@ColeHiggins2 ColeHiggins2 Awaiting requested review from ColeHiggins2
@synkd synkd Awaiting requested review from synkd

Assignees

@LadislavVasina1 LadislavVasina1

Labels

6.18.z Introduced in or relating directly to Satellite 6.18 6.19.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LadislavVasina1 @Satellite-QE @vsedmik @jnagare-redhat